[Functions] Bump javy
#4437
[Functions] Bump javy
#4437
Conversation
saulecabrera
changed the title
javy and function-runnerjavy and function-runner
saulecabrera
force-pushed
the
update-javy-and-function-runner
branch
7 times, most recently
from
f284e9c
to
fb2c99c
Compare
saulecabrera
changed the title
javy and function-runnerjavy
saulecabrera
force-pushed
the
update-javy-and-function-runner
branch
from
fb2c99c
to
ce38ee9
Compare
|
@andrewhassan / @DuncanUszkay1 I think this is ready for a review and 🎩 . I'm still figuring out why the tests are failing, on a first skim, failures seem unrelated, unless I'm missing something, so if you have any tips, I'd love to hear them. |
|
Oh actually one of them is related, taking a look. |
This commit updates the following versions: * `javy`: 3.0.1 -> 3.1.0
saulecabrera
force-pushed
the
update-javy-and-function-runner
branch
from
ce38ee9
to
772cd4c
Compare
| const FUNCTION_RUNNER_VERSION = 'v6.2.0' | ||
| const JAVY_VERSION = 'v3.1.0' |
There was a problem hiding this comment.
🤔 it's not clear to me from scanning this file what the upgrade process is here- it seems that as long as there's a javy executable in the bin, this version won't get downloaded when installBinary is called. Is that the intention?
There was a problem hiding this comment.
Yeah it is: in our previous model, javy would be automatically downloaded making the relationship between javy and cli versions 1:N; in our new model however, such relationship is switched to 1:1. A new CLI version doesn't pre-populate the bin directory, which means that when running the build or run commands for the first time the given javy version will be downloaded.
There was a problem hiding this comment.
So to answer your question more concretely, there's no automatic upgrade process, a javy version bump is tied to a cli version bump.
|
I'll have to close/re-open this PR, it seems that some of the CI scripts don't work as expected in forks. I'll switch to a branch instead. |
|
Opened #4444 instead. |
WHY are these changes introduced?
This commit updates the following versions:
javy: 3.0.1 -> 3.1.0The only functional change introduced as part of this PR is changing the invocation of
javy, which includes the new option groups, introduced in version 3.1.0.How to test your changes?
javy_quickjs_provider_v3Checklist